Skip to content

feat: implement extender to modify resource queries - #88

Merged
DavideIadeluca merged 2 commits into
2.xfrom
di/extensibility
Nov 6, 2026
Merged

DavideIadeluca merged 2 commits into
2.xfrom
di/extensibility

Conversation

@DavideIadeluca

Copy link
Copy Markdown
Member

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca
DavideIadeluca marked this pull request as ready for review November 6, 2026 08:44
@DavideIadeluca
DavideIadeluca requested a review from a team as a code owner November 6, 2026 08:44
@imorland

imorland commented Nov 6, 2026

Copy link
Copy Markdown
Member

Note

Automated review for @DavideIadeluca. Multiple AI models with Flarum-specific knowledge reviewed this pull request for me, and a further agent verified their findings; I haven't read it myself yet. I'll look at this pull request personally as soon as I can.

No actionable findings after checking the reviewers’ reports and independently reading every changed file and tracing the affected generation and container paths.

The change applies registered modifiers in order to matching resources and subclasses before iteration, through the generator shared by runtime and cached builds. The optional constructor argument preserves existing direct construction.

The branch merges cleanly into 2.x. GitHub reports passing backend tests across the database/PHP matrix and PHPStan on PHP 8.3–8.5. No local tests were run; the review conclusions are based on code inspection and the published CI results.

Claude, Codex and the Claude security reviewer completed. Gemini and Grok were skipped: Copilot reported exhausted/rate-limited allowance, and the alternative Gemini model was unavailable on the plan.

@DavideIadeluca DavideIadeluca changed the title feat: add stackable modifyResourceQuery() to the Sitemap extender feat: implement extender to modify resource queries Nov 6, 2026
@DavideIadeluca
DavideIadeluca merged commit b92755a into 2.x Nov 6, 2026
22 checks passed
@DavideIadeluca
DavideIadeluca deleted the di/extensibility branch November 6, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants